Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-3781

Fail Gracefully on UK Location Extensions missing County-ADS

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Mercury, Gooseberry
    • Fix Version/s: Mercury
    • Component/s: None
    • Labels:
      None

      Description

      There is a bug in the currently deployed code that when a UK stack tries to deploy an order with a location extension that is missing County (region), the order fails on deployment and goes to error. The bigger problem with this is that you cannot fix this order as tech ops would normally fix a failed deployment.

      If you set the order to archived and create a new one with the correct address, that order will fail since the GCE tries to use the old order. If you set the order to quote and edit it to fix the address and redeploy it immediately goes to error as well. The only work around is to create a new merchant and new order.

      We need ADS to fail in a way that this is recoverable and we can keep the merchant and just create a new order.

      Here are some errors from the log:

      Caused by: java.lang.NullPointerException
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.feed.FeedItemChangeRequest.setAttributeValue(FeedItemChangeRequest.java:165)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.feed.FeedItemChangeRequest.mapAttributeValues(FeedItemChangeRequest.java:135)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.feed.FeedItemChangeRequest.getFeedItems(FeedItemChangeRequest.java:86)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.feed.FeedItemChangeRequest.createRequest(FeedItemChangeRequest.java:37)

      2015-10-29 19:08:06.537 (4) [Timer-0]: ContentEditorPropertiesRefresher: contenteditor.properties last modified 1444834217000
      2015-10-29 19:09:04.551 (4) [Timer-5]: LicensingFileRefresher: licensing.properties last modified 1415372994000
      2015-10-29 19:09:06.537 (4) [Timer-0]: ContentEditorPropertiesRefresher: contenteditor.properties last modified 1444834217000
      2015-10-29 18:20:23.945 (2) [P7T1]: Exception running content editor, quitting

      These errors were found on aml-demo3-core1.

        Attachments

          Activity

            People

            • Assignee:
              Madhan Madhan Pulipati [X] (Inactive)
              Reporter:
              jeff.brown Jeff Brown (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: