Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-3892

Refactor set deployment status endpoint

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Apollo
    • Fix Version/s: Apollo
    • Component/s: API
    • Labels:
      None
    • Sprint:
      Sprint 8, Sprint 9

      Description

      The current endpoint for updating the status(active/paused/terminated) for a deployment is a PUT request to /deployments/by/status/

      {status}

      with the merchant id in the body of the request.

      This feels a bit odd.

      This should be changed to be a put to /deployments/

      {merchantUuid}

      /status so the deployment for a merchant is treated like a resource and we are just modifying that resource. The status value could continue to be passed in the body of the request or as a path parameter.

      The /

      {object}

      /by/

      {fieldname}

      /

      {fieldvalue}

      url scheme is used for filtering objects by their values because it reads very naturally for that purpose and the results of such a query is not a real resource.

        Attachments

          Activity

            People

            • Assignee:
              atul.sanagar Atul Sanagar (Inactive)
              Reporter:
              jason.stedman Jason Stedman (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: