Uploaded image for project: 'AdMax'
  1. AdMax
  2. ADMAX-2207

accountChannelMap must be removed from ReportService.Submit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2010 July - Third Wednesday
    • Component/s: Data Summarization
    • Labels:
      None
    • Environment:

      Operating System: Linux

      Platform: All

    • Bugzilla Id:
      3783

      Description

      report service had accountChannelMap put back in after a merge incorrectly resolved conflicts.

      The accountChannelMap was removed because not all channels were being returned.

      This is the revision that it was removed:

      http://trac.ri.thesearchagency.com/cgi-bin/trac.cgi/changeset/24026

      This is the revision that it was accidentally put back:

      http://trac.ri.thesearchagency.com/cgi-bin/trac.cgi/changeset/25009

      THERE MAY BE OTHER PROBLEMS with this merge as well. Please take care to look at the subversion history to ensure that any other problems are resolved correctly.

      == Background ==

      In the "Channel Rework" project we added some new channels and did some reorganization of distributions (I don't know the specifics). One of the changes we decided to make is to no longer require that accounts select specific channels in the setup wizard. This functionality was removed from the Account Setup Wizard UI. We also removed code from the report service that was filtering on this data as well. This functionality does still exist in the OLD account setup page, which is why most accounts still have data.

      == Problem ==

      A merge put the filter in the report service back into the code.

      == Impact ==

      Any reports pulled after it was put back in (around Feb 22, 2010) until we put the fix back in could potentially be missing data. I say potentially because in order to be missing data, they would need a pixel or datafeed that contains data for the distributions that are in channels which the accounts are not associated with.

      Example, there are 57 distributions in the Display channel. If Account X was not set up to be associated with "Display" in the account setup wizard, but they are advertising on Facebook, they would not be getting any data.

      There are 80 accounts that are affected. There are 7 accounts with no channels, and 73 accounts have a subset of channels.

      Attached is a list of queries and affected accounts.

      == Example ==

      The attached data.txt file has data in the warehouse for "Renovation Experts Display" but R-282-6406 (a report for the past 12 months, by day, by distribution) has no data in it.

        Attachments

          Activity

            People

            • Assignee:
              squadrim Mike Squadrito (Inactive)
              Reporter:
              squadrim Mike Squadrito (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: