Uploaded image for project: 'AdMax'
  1. AdMax
  2. ADMAX-2410

Google SearchEngineUpdater: campaign-level sync (--accounts) updates searchEngineAccounts unnecessarily

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Google
    • Labels:
      None

      Description

      On 10/11 at 5:00 PM we ran into performance issues on acctdb05 that caused replication to take much longer than usual.

      The below 2 columns store a CSV list of network targets and content targets. If Google returns the targets in a different order, it results in DB updates even though the targets are still the same.

      networkType

      contentType

      To fix this, we can stop using these columns, and replace all read/write references with the new TargetingDAO class. The TargetingDAO class makes these columns unnecessary, because all of the information is stored in the targeting database and retrieved using the targetingDAO. See YahooAPISearchEngine.ListingChunk.getListings() for an example usage of reading targets from the TargetingDAO.

      To view this happening, run the following query:

      mysql> select * from logging.searchEngineAccountChanges where `column` in ('networkType') and searchEngineAccountID=43 and changeTime > '2010-04-10';

      -------------------------------------------------------------------------------------------------------------------------------

      searchEngineAccountID changeTime tsaUserID sqlUser column oldValue newValue

      -------------------------------------------------------------------------------------------------------------------------------

      43 2010-04-10 02:07:37 0   networkType GoogleSearch,ContentNetwork CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-10 09:47:40 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-10 14:16:07 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-11 09:47:33 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-11 17:09:36 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-13 02:53:31 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-14 04:53:09 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-14 15:48:54 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-16 07:00:26 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-16 10:40:52 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-16 13:47:47 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-17 06:43:56 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-17 11:52:17 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-17 14:11:46 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-18 08:19:17 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH
      43 2010-04-18 18:15:50 0   networkType CONTENT_NETWORK,GOOGLE_SEARCH GOOGLE_SEARCH,CONTENT_NETWORK
      43 2010-04-19 06:58:48 0   networkType GOOGLE_SEARCH,CONTENT_NETWORK CONTENT_NETWORK,GOOGLE_SEARCH

      -------------------------------------------------------------------------------------------------------------------------------

      17 rows in set (0.03 sec)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              therouxj Jeff Theroux
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: