Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: unspecified
-
Component/s: Third Party Data
-
Labels:None
Description
The lines of data in the report have a blank string (as opposed to "0") for the following columns, which is causing it to skip the line. It looks like if the row contains even one empty field (regardless of if it is defined in the required headers) it will skip the line. That is not the behavior we want. I think we should only be checking the required columns and failing if they have blank values.
conversions
cost per conversion
unique impressions
unique clicks
uCTR
A fix was put in in rev 28768 but that broke all omniture unified datafeeds, so it had to be reverted.
http://trac.ri.thesearchagency.com/cgi-bin/trac.cgi/changeset/28768
Testing for the original bug was done by Atul on staging-xml1. Here is the command he used to test.
./load-publisher.sh -d3 -F -XN ASK.xml -XL /var/local/tsa/publisherfeedConfig/ 2>&1|tee /tmp/ask3.log
Atul said he had to comment out the CampaignID and CampaignName tags from original ASK.xml
<!-- Provide the mapping between the data feed columns and the database table and column -->
<headerBehaviorType>DefaultHeaderBehavior</headerBehaviorType>
<!-- <headerNames>CampaignID</headerNames>-->
<!-<headerNames>CampaignName</headerNames>->
<headerNames>AdGroupID</headerNames>
<headerNames>AdGroupName</headerNames>
There is a unit test added in r29572 to help ensure fixing this does not break omniture unified feeds. Instructions on how to execute are in the code.
http://trac.ri.thesearchagency.com/cgi-bin/trac.cgi/changeset/29572