Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: Data Summarization
-
Labels:None
-
Environment:
xml-06.dc1bos.thesearchagency.com
/usr/local/tsa/bidmgr -> tsa-build-bidmgr-2012-01-30-p16-r31446/
Description
Logic in sesumm (getCostAndClicks) for quality score does not make sense (anymore.. maybe it did before seupdate was changed)
Only getCostAndClicks writes to sourceBidType table (previously seupdate did.. still does in Yell) but the logic for quality score was to query that table for a value and if QS > 0, take the average of that value and the value from the staging.googleMcc table. That is incorrect. Querying that table is not necessary at all because the average should not be used. The value in that table should represent the last performance QS (or be null/0 if there has never been performance QS). So it should insert/update QS only from the value retrieved by the staging.googleMcc table.
The expected behavior:
> 1) sourceBidType does not have a row when sesumm is run, so a new row is inserted
> a) QS> 0 so sourceID, bidTypeID, qualityScore and firstPageBid get inserted with values from staging table
> b) QS = 0 so sourceID, bidTypeID and firstPageBid get inserted with values from staging table.. QS gets default value of NULL
>
> 2) sourceBidType has a row when sesumm is run, so the row is updated
> a) QS> 0 so qualityScore and firstPageBid get updated with values from staging table
> b) QS = 0 so firstPageBid gets updated with value from staging table, QS is not updated