Uploaded image for project: 'AdMax'
  1. AdMax
  2. ADMAX-974

account settings lost when a deactivated form is submitted

    Details

    • Bugzilla Id:
      1736

      Description

      The lost settings with timestamps can be seen here:

      select accountChanges.changeTime, `column`, newValue, tsaUserID, sqluser from
      accountChanges where accountID=225 ;
      select accountChanges.changeTime, `column`, newValue, tsaUserID, sqluser from
      accountChanges where accountID=17;

      Reproduction steps:
      1) Deactivate the CSC account

        • This can only be reproduced by starting with a deactivated account
          2) click "active" to enable the form elements
          3) click "inactive" to disable the form elements
          4) Click "save changes"

      Explanation:
      The form with disabled elements is now submitted. The Javascript thinks
      "isActive" has not changed, so the rest of the form is handled normally (as if
      you were just editing normal account settings). But since all of the elements
      are disabled, they're all handled as blank/empty and nulls are set. The
      following queries are done:

      1. Tier/Priority, Performance Metric, Client Provides Conversion Data, Bid
        Management settings
        update `tsacommon`.`accounts` set tier=null, isBidManaged=null, perfMetric=null,
        providesConversionData=null where (`id` = "17");
      1. Ignore TSA Waypoints setting
        update `tsacommon`.`sites` set ignorePixels=null where (`id` = "35");
      1. Channel Selection setting
        delete from `st-tracker`.`accountChannelMap` where ((`accountID` = 17) and
        (`channelID` = 1));

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              therouxj Jeff Theroux
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: