Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-100

Point Radius Modifier jobs sometimes add another PR instead of updating it

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None
    • Environment:

      optus dev environment

      Description

      (11:25:34 AM) Me: I fixed the bug Atul found preventing point radius modifiers from working (SMB-150) and got it working... it updates just fine
      (11:26:19 AM) Me: don't think we need to make any changes to the API call
      (11:27:07 AM) Me: are there specific test cases in mind you want me to try? i've tried adding a positive and negative multiplier
      (11:31:40 AM) Me: I'll check if it's different in Yell but in SMB the CampaignCriterionDTO object (which gets mapped to the object sent to Google) contains the Operator and is set by the CampaignTargetChangeRequest methods appropriately (ie. update = delete then add) .. in fact, I mirrored site links after this
      (11:36:18 AM) Me: yup, Yell matches.. Ana started making these changes at this revision: http://murky-svn/trac-tsa/changeset/2006
      (01:30:36 PM) Me: I just reproduced the issue you were concerned about have to debug to figure out why sometimes it works as expected and sometimes it doesn't - you can see 2 PR here https://adwords.google.com/cm/CampaignMgmt?__u=2395913484&__c=5891766324&syncServiceIdentity=true#r.ONLINE.st&app=cm (note I'm still working on Brand campaign)

      This bug isn't a big deal if the radius is increased, but if the radius is decreased the bigger radius will still be targeted.

        Attachments

          Activity

            People

            • Assignee:
              caitlyn Caitlyn Duggan (Inactive)
              Reporter:
              caitlyn Caitlyn Duggan (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: