Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-109

ADS updateCampaignStatus failing if partial list of campaigns for the customer are sent in ('Budgets cannot be 0')

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None
    • Environment:

      all Optus environments; bidmgr

      Description

      updateCampaignStatus is giving a strange error if not all campaigns for the customer are passed into the request: Budgets cannot be 0

      I just tested in dev and get the 'Budgets cannot be 0' error when sending a partial list of campaigns for a customer that has a Brand campaign deployed. On the flip side, when I try sending a partial list of campaigns for a customer that does NOT have a Brand campaign deployed, I do not get the error. This seems like a bug to me.

      Fix: allow a partial list of campaigns to be sent into the request regardless of whether a Brand campaign is deployed or not; that is, don't fail if not all the customer's campaigns are sent in

      TODO: test how this affects Brand campaign deriving its status from the status of all the customer's campaigns... probably will have to make a DB call so Brand campaign can still derive its status from ALL standard campaigns, whether they're passed into the request or not

        Attachments

          Activity

            People

            • Assignee:
              caitlyn Caitlyn Duggan (Inactive)
              Reporter:
              caitlyn Caitlyn Duggan (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: