Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: Apponaug
-
Component/s: None
-
Labels:None
-
Sprint:Wickford - Sprint 1, Wickford - Sprint 2, Wickford - Sprint 3, Wickford - Sprint 4
Description
As highlighted in AML-1601, for adding text ads and keywords, each ad group gets 2 calls respectively – one validates the request and the second sends the "real" add request
GCE has logic to remove any erroneous ads/keywords retrieved from the validate request and then TSA sends all the "good" ads/keywords. The problem is validate requests and real requests both factor into our rate limit, so it'd be great if we could make only 1 call per ad group for adding text ads and keywords, respectively.
In comes Google's partialFailure flag: https://developers.google.com/adwords/api/docs/headers#partialFailure
By setting this flag, we can get the same functionality - Google will add all the "good" ads and keywords, and will return the ones in error. GCE will need to be updated to handle API errors at this step, and remove the validate step.
Bottom line: cut # of API calls for ads and keywords in half
