Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-2359

Use correct "no end date" values

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Johnston
    • Fix Version/s: Goa
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Goa Sprint 1

      Description

      This affects two parts of the API (GoogleAdWordsAPIReseller / GoogleContentEditor)

      • BudgetOrderService
      • CampaignService

      https://developers.google.com/adwords/api/docs/reference/v201309/BudgetOrderService.BudgetOrder (endDateTime = "20371230 235959 America/Los_Angeles")
      https://developers.google.com/adwords/api/docs/reference/v201309/CampaignService.Campaign (endDate = "20371230")

      When we make API calls with end dates, we should use the "no end date" end dates provided in the documentation.

      The code for the budget end date is in:

      GoogleAccountChangeRequest.getBudgetNoEndDate() (currently set for 2036/12/31 23:59:59 in the code)

      We do not set the campaign end date but AdWords sets it to "20371230" after we make the CampaignService.mutate call to add the campaign. It's probably a good idea to set the end date ourselves.

        Attachments

        1. budget_no_end_date_soap.doc
          15 kB
          Stacie Waleyko
        2. campaign_no_end_date.doc
          42 kB
          Stacie Waleyko
        3. check_budget_end_date.jpg
          104 kB
          Stacie Waleyko
        4. check_campaign_end_date.jpg
          139 kB
          Stacie Waleyko

          Issue Links

            Activity

              People

              • Assignee:
                stacie.waleyko Stacie Waleyko (Inactive)
                Reporter:
                therouxj Jeff Theroux
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: