Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-2427

CLONE - When a keyword or ad is rejected by google during campaign deployment, GCE error tables need to store the reason why the keyword or ad was disapproved.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Johnston 2.2.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      JP Demo (aq-demo2)

    • Story Points:
      5
    • Sprint:
      Sprint 6

      Description

      This bug is related to keywords and ads

      In NTT Demo the following account with merchant UUID: 1f6d7a77-3a35-40f7-8364-0d232222727a failed to deploy with a keyword error.
      AML returned this as: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0

      To find out the actual cause of the reason, techOps had to search through /tmp/google_logs/soap_xml.log with the searchengineidentifier of the adgroup which had the keyword error, to determine the error.

      The error in soap_xml.log was:
      <fieldPath>operations[10].operand.criterion.text</fieldPath>
      <trigger>??</trigger>
      <errorString>CriterionError.KEYWORD_HAS_INVALID_CHARS</errorString>
      <ApiError.Type>CriterionError</ApiError.Type>
      <reason>KEYWORD_HAS_INVALID_CHARS</reason>
      </partialFailureErrors>

      The error handling code needs to return the actual reason why google rejected the keyword which is : KEYWORD_HAS_INVALID_CHARS

      Google API errors should be included in the content editor error table...

      2013-10-14 15:42:34.744 (3) [pool-2594-thread-1]: TextAdChangeRequest (accountID 27): Sending 4 add requests
      2013-10-14 15:42:34.745 (3) [pool-2594-thread-2]: TextAdChangeRequest (accountID 27): Sending 4 add requests
      2013-10-14 15:42:34.748 (3) [pool-2594-thread-3]: TextAdChangeRequest (accountID 27): Sending 4 add requests
      2013-10-14 15:42:35.037 (2) [pool-2594-thread-1]: Unknown / unexpected exception [java.lang.ArrayIndexOutOfBoundsException]. msg=0
      2013-10-14 15:42:35.037 (1) [pool-2594-thread-1]: Exception [unhandled exception]:java.lang.ArrayIndexOutOfBoundsException: 0
      at com.thesearchagency.searchengines.google.GoogleAdWordsAPI.addAdList(GoogleAdWordsAPI.java:4239)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.TextAdChangeRequest.sendRequest(TextAdChangeRequest.java:58)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.TextAdChangeRequest.sendRequest(TextAdChangeRequest.java:34)
      at com.thesearchagency.searchengines.google.contenteditor.changerequest.BaseChangeRequest.makeRequest(BaseChangeRequest.java:124)
      at com.thesearchagency.searchengines.google.contenteditor.GoogleContentEditor$RequestWorker.call(GoogleContentEditor.java:1605)
      at com.thesearchagency.searchengines.google.contenteditor.GoogleContentEditor$RequestWorker.call(GoogleContentEditor.java:1582)
      at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
      at java.util.concurrent.FutureTask.run(FutureTask.java:138)
      at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
      at java.lang.Thread.run(Thread.java:662)

      2013-10-14 15:42:35.037 (3) [pool-2594-thread-1]: Caught other/unrecoverable API Error: "java.lang.ArrayIndexOutOfBoundsException"
      2013-10-14 15:42:35.053 (3) [pool-2594-thread-1]: TextAdDAO(accountID 27): Inserted 4 Errors: Updated 4 pending changes, cleared 0 existing errors.
      2013-10-14 15:42:35.053 (3) [pool-2594-thread-1]: TextAdChangeRequest (accountID 27): Errors recorded, no more changes to process
      2013-10-14 15:42:35.054 (2) [pool-2594-thread-1]: Google Request Errors for accountID 27(TextAdChangeRequest)

      H:

      {KeyWord:Flawless Chemical Peels}

      D1: Great Service, Competitive Pricing.
      D2: Chemical Peels For Smooth Skin.
      id=391, code=-1: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0(reason: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0)(isExemptable: false), trigger=, field=

      H:

      {KeyWord:Clear Skin Chemical Peels}

      D1: Put Time Into Caring For Yourself.
      D2: A Superior Chemical Peel Treatment.
      id=389, code=-1: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0(reason: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0)(isExemptable: false), trigger=, field=

      H: Flawless Chemical Peels
      D1: Chemical Peels For Smooth Skin.
      D2: Great Service, Competitive Pricing.
      id=390, code=-1: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0(reason: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0)(isExemptable: false), trigger=, field=

      H: Clear Skin Chemical Peels
      D1: A Superior Chemical Peel Treatment.
      D2: Put Time Into Caring For Yourself.
      id=388, code=-1: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0(reason: Internal Error [java.lang.ArrayIndexOutOfBoundsException]0)(isExemptable: false), trigger=, field=

        Attachments

          Activity

            People

            • Assignee:
              caitlyn Caitlyn Duggan (Inactive)
              Reporter:
              manasa.denning Manasa Denning
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: