Details
-
Type:
Bug
-
Status: Reopened
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: Jamestown 2.3.0
-
Fix Version/s: All Time Backlog
-
Component/s: Admax Deployment Service
-
Labels:None
-
Story Points:13
-
Sprint:High Priority
Description
Errors should not be removed from the db so that tech ops has info to resolve issues as needed. ADS UpdateRequest should not be doing anything with ads or keywords. This should be handled only in DeploymentRequest.
In Jamestown, deployments ignore text ad errors and sets the deployment status to SUCCEEDED. Previously ad errors would cause FAILED.
When campaigns are set to active via ADS updateCampaign request, the campaigns are "retried" which removes the ads and their errors. The status is set to ACTIVE or SUCCESS or something affirmative in the UI.
The errors are still captured in an email so an action can be taken to resolve them in the UI and redeploy the campaigns, which is why this is marked as minor.
For more (potentially confusing and offensive) information, see AML-2427
Patrick tested AML-2462 in Jamestown and found that the update request is made but it redundantly sets the status to paused. That also leads to this problem and also does some of the work only deployments should do.