Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-2830

Initial bid can be greater than the budget in db

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Diu
    • Fix Version/s: Diu
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Sprint 5

      Description

      When we save the initial bid to the st-tracker.admaxBids table there are no checks to make sure the default bid is not greater than the budget.

      Steps to reproduce:

      1. Deploy an account with one BA/BL and a small budget (like $5.33). Set the default bid in algorithm.properties to something higher like 0.3
      2. Check the admaxBids table and observe that the value for 'currentBid' is greater than the (correct) max CPC that is in AdWords. In this example the Max CPC should be 0.09 (the daily budget) but the admaxBids table has it listed as 0.3

        Attachments

          Activity

            People

            • Assignee:
              varshini.padmanabhan Varshini Padmanabhan (Inactive)
              Reporter:
              stacie.waleyko Stacie Waleyko (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: