Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: Fuji
-
Fix Version/s: Fuji
-
Component/s: Admax Deployment Service
-
Labels:None
-
Sprint:Sprint 10
Description
Running ABU on a deleted campaign throws exception
Steps:
1) Create an order with any budget and deploy
2) Delete/terminate the order
3) Run abu for the deleted order
ABU log:
[TSAApp@aml-qa3-core1 bidmgr]$ ./admax.sh -d3 -T2014-10-29 -a 1103
2014-10-29 15:21:39.517 (3) [main]: Debug Level set to 3
2014-10-29 15:21:39.519 (3) [main]: Licensing environment detected, loading configuration.
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.clientId=708478822263-srenocq0gcguusttt4aunqjdi2jnllcg.apps.googleusercontent.com
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.clientSecret=eGE8JpEDaEgVb26gQg_ePnaG
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.refreshToken=1/PPPmQLADSV-h2NEsY4vmLgBmiDtScaB01K55xhGOaHE
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.developerToken=ojCnjZaM6RD1h0yt_DOJZg
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.isReseller=true
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.google.mcc.userAgent=AdMaxLocal AdWords Software TSA QA
2014-10-29 15:21:39.520 (3) [main]: Loaded property: tsa.timezone=UTC
2014-10-29 15:21:39.527 (3) [main]: Debug Level set to 3
2014-10-29 15:21:39.527 (3) [main]: AdMax Summarizer parameters: -d3 -T2014-10-29 -a 1103
2014-10-29 15:21:39.903 (3) [main]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:39.935 (3) [main]: DatabasePool with a limit of 18 created
2014-10-29 15:21:39.983 (3) [main]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.030 (3) [main]: Could not save process history start
2014-10-29 15:21:40.031 (3) [main]: =============== Starting AdMax Summarizer ================
2014-10-29 15:21:40.031 (3) [main]: ----------------AdMax Summarizer starting
2014-10-29 15:21:40.064 (3) [main]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.081 (3) [P1T1]: Starting Account ID #1103: a9b888f0-839f-428a-869d-b39c073b591c
2014-10-29 15:21:40.111 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.119 (3) [P1T1]: DatabasePool with a limit of 18 created
2014-10-29 15:21:40.142 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.144 (3) [P1T1]: DatabasePool with a limit of 18 created
2014-10-29 15:21:40.168 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.191 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.194 (3) [P1T1]: DatabasePool with a limit of 18 created
2014-10-29 15:21:40.223 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.244 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.246 (3) [P1T1]: DatabasePool with a limit of 18 created
2014-10-29 15:21:40.273 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.276 (3) [P1T1]: Got migrator lock for Account ID #1103
2014-10-29 15:21:40.315 (3) [P1T1]: Applying algorithm [SABB] for Account ID #1103 in distributions [3, 178]
2014-10-29 15:21:40.322 (3) [P1T1]: Processing data for 2014-10-29 00:00:00 UTC
2014-10-29 15:21:40.406 (3) [P1T1]: Retrieved campaign status Deleted for AdMax campaign 1750
2014-10-29 15:21:40.412 (3) [P1T1]: Retrieved campaign status Deleted for AdMax campaign 1750
2014-10-29 15:21:40.444 (3) [P1T1]: Could not find boosted carryover for AdMaxCampaignID: 1750
2014-10-29 15:21:40.452 (3) [P1T1]: Could not find boosted actual daily budget for AdMaxCampaignID: 1750
2014-10-29 15:21:40.466 (3) [P1T1]: Could not find balance factor for searchEngineAccountID: 3594
2014-10-29 15:21:40.467 (3) [P1T1]: Could not find balance factor for searchEngineAccountID: 3595
2014-10-29 15:21:40.474 (3) [P1T1]: Could not find actual daily budget for searchEngineAccountID: 3594
2014-10-29 15:21:40.475 (3) [P1T1]: Could not find actual daily budget for searchEngineAccountID: 3595
2014-10-29 15:21:40.483 (3) [P1T1]: AdMaxSABBBudgetSlosher theDate = Wed Oct 29 00:00:00 UTC 2014
2014-10-29 15:21:40.511 (3) [P1T1]: Budget capped at: 0.0
2014-10-29 15:21:40.604 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.636 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.661 (3) [P1T1]: JDBC Driver Version: 5.1 (com.mysql.jdbc.Driver)
2014-10-29 15:21:40.661 (3) [P1T1]: Created shared sesystem connection rw
2014-10-29 15:21:41.684 (3) [P1T1]: [oauth] Creating new OAuthService component
2014-10-29 15:21:41,687 [P1T1] INFO c.t.s.o.core.OAuthServiceComponent - [oauth] Creating new OAuthServiceComponent
2014-10-29 15:21:41,723 [P1T1] INFO c.t.s.o.core.OAuthServiceComponent - [oauth] Getting new access token
2014-10-29 15:21:42,669 [P1T1] INFO c.t.s.o.core.OAuthServiceComponent - [oauth] Return OAuth credential. Access token = ya29.rQAoGyfS8KIKWPB5CupAe0EZKnk5vrFORI97Mq1FMKfdo3U03c14WWx8
2014-10-29 15:21:42.669 (3) [P1T1]: [oauth] Returning access token from OAuth service: ya29.rQAoGyfS8KIKWPB5CupAe0EZKnk5vrFORI97Mq1FMKfdo3U03c14WWx8
2014-10-29 15:21:42,670 [P1T1] INFO c.t.s.o.core.OAuthServiceComponent - [oauth] Return OAuth credential. Access token = ya29.rQAoGyfS8KIKWPB5CupAe0EZKnk5vrFORI97Mq1FMKfdo3U03c14WWx8
2014-10-29 15:21:42.671 (3) [P1T1]: [oauth] Returning access token from OAuth service: ya29.rQAoGyfS8KIKWPB5CupAe0EZKnk5vrFORI97Mq1FMKfdo3U03c14WWx8
2014-10-29 15:21:43,779 [P1T1] INFO c.g.a.a.a.l.c.A.requestInfoLogger - Request made: Service: "BudgetServiceInterfacePort" Method: "mutate" URL: "https://adwords.google.com/api/adwords/cm/v201406/BudgetService"
2014-10-29 15:21:43,795 [P1T1] INFO c.g.a.a.a.l.c.A.soapXmlLogger - SOAP Request:
<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<soapenv:Header>
<ns1:RequestHeader xmlns:ns1="https://adwords.google.com/api/adwords/cm/v201406" soapenv:mustUnderstand="0">
<ns1:clientCustomerId>8696496259</ns1:clientCustomerId>
<ns1:developerToken>ojCnjZaM6RD1h0yt_DOJZg</ns1:developerToken>
<ns1:userAgent>AdMaxLocal AdWords Software TSA QA (AwApi-Java, AdWords-Axis/1.31.0, Common-Java/1.31.0, Axis/1.4, Java/1.6.0_27, maven)</ns1:userAgent>
<ns1:validateOnly>false</ns1:validateOnly>
<ns1:partialFailure>false</ns1:partialFailure>
</ns1:RequestHeader>
</soapenv:Header>
<soapenv:Body>
<mutate xmlns="https://adwords.google.com/api/adwords/cm/v201406">
<operations>
<operator>SET</operator>
<operand>
<budgetId>340216322</budgetId>
<period>DAILY</period>
<amount>
<microAmount>10000</microAmount>
</amount>
</operand>
</operations>
<operations>
<operator>SET</operator>
<operand>
<budgetId>340216442</budgetId>
<period>DAILY</period>
<amount>
<microAmount>10000</microAmount>
</amount>
</operand>
</operations>
</mutate>
</soapenv:Body>
</soapenv:Envelope>
2014-10-29 15:21:43,795 [P1T1] INFO c.g.a.a.a.l.c.A.soapXmlLogger - SOAP Response:
<?xml version="1.0" encoding="UTF-8"?>
<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
<soap:Header>
<ResponseHeader xmlns="https://adwords.google.com/api/adwords/cm/v201406">
<requestId>00050691524271800ab6720332001e79</requestId>
<serviceName>BudgetService</serviceName>
<methodName>mutate</methodName>
<operations>0</operations>
<responseTime>71</responseTime>
</ResponseHeader>
</soap:Header>
<soap:Body>
<mutateResponse xmlns="https://adwords.google.com/api/adwords/cm/v201406">
<rval>
<ListReturnValue.Type>BudgetReturnValue</ListReturnValue.Type>
<value>
<budgetId>340216322</budgetId>
<name>a9b888f0-839f-428a-869d-b39c073b591c_10008_44_5544_GT</name>
<period>DAILY</period>
<amount>
<ComparableValue.Type>Money</ComparableValue.Type>
<microAmount>10000</microAmount>
</amount>
<deliveryMethod>STANDARD</deliveryMethod>
<isExplicitlyShared>true</isExplicitlyShared>
<status>ENABLED</status>
</value>
<value>
<budgetId>340216442</budgetId>
<name>a9b888f0-839f-428a-869d-b39c073b591c_10008_44_5544_GM</name>
<period>DAILY</period>
<amount>
<ComparableValue.Type>Money</ComparableValue.Type>
<microAmount>10000</microAmount>
</amount>
<deliveryMethod>STANDARD</deliveryMethod>
<isExplicitlyShared>true</isExplicitlyShared>
<status>ENABLED</status>
</value>
</rval>
</mutateResponse>
</soap:Body>
</soap:Envelope>
2014-10-29 15:21:43.804 (3) [P1T1]: Exception [Could not update campaign]:java.lang.NullPointerException
at com.thesearchagency.admax.algorithms.common.GoogleBudgetUpdateManager.executeBulkUserCampaignUpdates(GoogleBudgetUpdateManager.java:102)
at com.thesearchagency.admax.algorithms.sabb.AdMaxSABBAlgorithm.updateSearchEngineAccounts(AdMaxSABBAlgorithm.java:600)
at com.thesearchagency.admax.algorithms.sabb.AdMaxSABBAlgorithm.applyAlgorithm(AdMaxSABBAlgorithm.java:232)
at com.thesearchagency.admax.AdMaxSummarizer$AccountWorker.call(AdMaxSummarizer.java:594)
at com.thesearchagency.admax.AdMaxSummarizer$AccountWorker.call(AdMaxSummarizer.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
2014-10-29 15:21:43.823 (3) [P1T1]: Finished applying algorithm [SABB] for account [1103] in distributions [3, 178]
2014-10-29 15:21:43.824 (3) [P1T1]: Released migrator lock for Account ID #1103
2014-10-29 15:21:43.824 (3) [P1T1]: Completed Account ID #1103: a9b888f0-839f-428a-869d-b39c073b591c
2014-10-29 15:21:43.825 (3) [main]: ------------AdMax Summarizer done
2014-10-29 15:21:43.825 (3) [main]: =============== Completed AdMax Summarizer ================
2014-10-29 15:21:43.826 (3) [main]: Could not save process history stop
2014-10-29 15:21:43.826 (3) [main]: =============== Stats ================
2014-10-29 15:21:43.826 (3) [main]: — Process —
2014-10-29 15:21:43.826 (3) [main]:
2014-10-29 15:21:43.826 (3) [main]: ABU Process(start): Wed Oct 29 15:21:39 UTC 2014
2014-10-29 15:21:43.827 (3) [main]: ABU Process(stop): Wed Oct 29 15:21:43 UTC 2014
2014-10-29 15:21:43.827 (3) [main]:
2014-10-29 15:21:43.827 (3) [main]: — Accounts —
2014-10-29 15:21:43.827 (3) [main]:
2014-10-29 15:21:43.827 (3) [main]: Accounts Processed: 1
2014-10-29 15:21:43.827 (3) [main]: Accounts Skipped: 0
2014-10-29 15:21:43.827 (3) [main]: Accounts Processed Successfully: 0
2014-10-29 15:21:43.827 (3) [main]:
2014-10-29 15:21:43.827 (3) [main]: — Campaigns —
2014-10-29 15:21:43.827 (3) [main]:
2014-10-29 15:21:43.827 (3) [main]: Campaigns Processed: 1
2014-10-29 15:21:43.827 (3) [main]: Campaigns Processed Successfully: 0
2014-10-29 15:21:43.827 (3) [main]: Campaign Budgets Capped: 1
2014-10-29 15:21:43.828 (3) [main]:
2014-10-29 15:21:43.828 (3) [main]: — SE Campaigns —
2014-10-29 15:21:43.828 (3) [main]:
2014-10-29 15:21:43.828 (3) [main]: SE Campaigns Processed: 2
2014-10-29 15:21:43.828 (3) [main]: SE Campaigns Processed Successfully: 0
2014-10-29 15:21:43.828 (3) [main]:
2014-10-29 15:21:43.828 (3) [main]: — Budget/Spend —
2014-10-29 15:21:43.828 (3) [main]:
2014-10-29 15:21:43.828 (3) [main]: SE Campaign Budgets Updated: 2
2014-10-29 15:21:43.828 (3) [main]: SE Campaign Budgets Sent To Google: 2
2014-10-29 15:21:43.828 (3) [main]: SE Campaign Budgets Sent To Yahoo Japan:0
2014-10-29 15:21:43.828 (3) [main]:
2014-10-29 15:21:43.828 (3) [main]: Spend Total: 0.0
2014-10-29 15:21:43.828 (3) [main]: Common Carryover Total: 0.06451613
2014-10-29 15:21:43.829 (3) [main]:
2014-10-29 15:21:43.829 (3) [main]: — Bids —
2014-10-29 15:21:43.829 (3) [main]:
2014-10-29 15:21:43.829 (3) [main]: New Campaign Bids: 0
2014-10-29 15:21:43.829 (3) [main]:
2014-10-29 15:21:43.830 (3) [main]: AdMaxSummarizer: 4.220s
2014-10-29 15:21:43.830 (3) [main]: by key:
2014-10-29 15:21:43.830 (3) [main]: db: 0.059s
2014-10-29 15:21:43.830 (3) [main]: by thread:
2014-10-29 15:21:43.830 (3) [main]: P1T1: 0.054s
2014-10-29 15:21:43.831 (3) [main]: main: 0.005s
2014-10-29 15:21:43.831 (3) [main]: google: 1.099s
2014-10-29 15:21:43.831 (3) [main]: other: 3.062s
[TSAApp@aml-qa3-core1 bidmgr]$
Actual Result: NullPointerException seen
Expected Result: No exception should occur