Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-3209

yj-soap-client returns a null pointer exception for campaign updates with bad searchEngineIdentifiers

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Fuji
    • Fix Version/s: Kinsei
    • Component/s: None
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Sprint 2, Sprint 3

      Description

      In testing AML-3206 I tried to generate an API error to test the error path for campaign status updates. I used the following SQl statements to generate the error by changing the searchEngineIdentifier from 922428 to 92242800:

      update tsacommon.searchEngineAccounts set searchEngineIdentifier = 92242800 where ID = 1001;
      update yjp.campaigns set yahooId = 92242800, json = replace(json,'922428','92242800') where id = 457;

      The Y!J API returns a DEACTIVATED response error but the UpdateCampaignStructure class returns a null pointer exception from line 164 (if (opResult.getItem().getSearchEngineId().equals(requested.getSearchEngineId())) {) because the opResult has no Item. Phej and I tried to fix this by populating the item in the ResponseMapper even for errors, but the YahooCampaignService class interprets the presence of a searchEngineIdentifier as a successful response.

      Pulling this thread was getting too involved to be done so late in Fuji. This should be addressed later.

        Attachments

          Activity

            People

            • Assignee:
              varshini.padmanabhan Varshini Padmanabhan (Inactive)
              Reporter:
              rgardner Ross Gardner
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: