Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: Mercury
-
Fix Version/s: Mercury
-
Component/s: Admax Deployment Service
-
Labels:None
-
Environment:
Bid Manager : bidmgr-distribution-2.9.0-SNAPSHOT-dev-t20150821065942 (build #814)
Core : smb-ear-2.9.0-SNAPSHOT-b348-t20150817-155741-CI.ear (build #349)
SAPI : aml-sapi-2.9.0-20150818.183757-103.war (#1042)
Reseller : aml-ui-reseller-gwt-2.9.0-20150813.221022-7.war (#259)
Techops : ops-scripts-2.8.0-20150818.142033-56-bin.zip(#736)
AML Distribution Service: Build67Bid Manager : bidmgr-distribution-2.9.0-SNAPSHOT-dev-t20150821065942 (build #814) Core : smb-ear-2.9.0-SNAPSHOT-b348-t20150817-155741-CI.ear (build #349) SAPI : aml-sapi-2.9.0-20150818.183757-103.war (#1042) Reseller : aml-ui-reseller-gwt-2.9.0-20150813.221022-7.war (#259) Techops : ops-scripts-2.8.0-20150818.142033-56-bin.zip(#736) AML Distribution Service: Build67
-
Sprint:Sprint 7
Description
For Bid amount less than floor price, listener throws Null pointer exception!
Steps:
1.Deploy a campaign having budget less than floor price.
<customer>
<customerID>d193d108-6698-49f7-8b18-9f91819f0cfe</customerID>
<domainName>www.merchantsite.com</domainName>
<budget>1</budget>
<anniversaryDate>2015-08-24</anniversaryDate>
<currencyCode>USD</currencyCode>
<timeZone>America/New_York</timeZone>
<countryCode>US</countryCode>
2.Observe the listener log
Actual result:
Campaign gets deployed successfully with Null pointer exception for
"Bid amounts are less than floor price"
Snippet of listener log:
Content-Type: text/xml; charset=utf-8
Headers:
Payload: <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Body><s:Fault><faultcode>s:Server</faultcode><faultstring xml:lang="en-US">Invalid client data. Check the SOAP fault details for more information</faultstring><detail><ApiFaultDetail xmlns="https://bingads.microsoft.com/CampaignManagement/v9" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><TrackingId xmlns="https://adapi.microsoft.com">e6c5309d-0dcf-462b-acdd-924bda3fe58e</TrackingId><BatchErrors><BatchError><Code>1515</Code><Details i:nil="true"/><ErrorCode>CampaignServiceBidAmountsLessThanFloorPrice</ErrorCode><Index>0</Index><Message>Bid amounts are less than floor price.</Message><Type>BatchError</Type></BatchError></BatchErrors><OperationErrors/></ApiFaultDetail></detail></s:Fault></s:Body></s:Envelope>
--------------------------------------
2015-08-24 07:11:11,899 [pool-3-thread-3] INFO c.t.s.c.b.u.e.i.CampaignServiceErrorEntityFactory - Bing ApiFault BatchError Found:1
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - ******* Error *******
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - code = 1515
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - message = Bid amounts are less than floor price.
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - errorCode = CampaignServiceBidAmountsLessThanFloorPrice
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - details = null
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - errorType = BatchError
2015-08-24 07:11:11,899 [pool-3-thread-3] DEBUG c.t.s.client.bing.util.SoapUtils - index = 0
2015-08-24 07:11:11,899 [pool-3-thread-3] INFO c.t.s.c.bing.impl.request.Request - isRetryableGenericException: handling java.lang.NullPointerException (message=null)
2015-08-24 07:11:11,900 [pool-3-thread-3] WARN c.t.s.c.bing.impl.request.Request - Could not retry Exception with request
java.lang.NullPointerException: null
at com.thesearchagency.services.client.bing.impl.request.ResponseMapper.handle(ResponseMapper.java:44) ~[deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.serviceclient.AdGroupServiceClient$1.sendRequest(AdGroupServiceClient.java:170) ~[deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.request.Request.requestLoop(Request.java:52) [deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.request.Request.call(Request.java:36) [deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.serviceclient.ServiceClient.executeRequest(ServiceClient.java:40) [deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.serviceclient.AdGroupServiceClient.addAdGroups(AdGroupServiceClient.java:173) [deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
at com.thesearchagency.services.client.bing.impl.BingAdsClient.addAdGroups(BingAdsClient.java:234) [deployment-bidmgr-shaded-jar-2.9.0-SNAPSHOT.jar:na]
Expected Result:
Null pointer exception should be handled.