Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-3695

ReportService and PerformanceReportService are unclear

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Mercury
    • Fix Version/s: All Time Backlog
    • Component/s: API
    • Environment:

      aml-sapi feature/mercury branch

      Description

      The requirements for obtaining reports in both ReportService and PerformanceReportService are unclear.

      In both services, there is an argument "@Context UriInfo aUriInfo" in the methods to obtain reports. From what I can tell, this is used to process additional arguments in the URI.

      However, the parameterized SQL for merchant reports only accepts 1 argument, and the reseller reports SQL only accepts 3 arguments. Any more and the request results in a 500 error due to an incorrect number of parameters.

      For ReportService, it is possible to ask for a daily report using a date which does not specify a day.
      ie. reports/2012/12/DAILY_RESELLER_PERFORMANCE_REPORT

      Or a monthly report which does not specify a month
      ie. reports/2012/MONTHLY_RESELLER_PERFORMANCE_REPORT

      These requests return empty reports. Should DAILY_RESELLER_PERFORMANCE_REPORT be required to specify a day? Should MONTHLY_RESELLER_PERFORMANCE_REPORT be required to specify a month?

      These questions on requirements are probably applicable to PerformanceReportService, but I believe it was written so that if a month is given when requesting DAILY_RESELLER_PERF_REPORT it will fetch all daily performance reports for that month. I will go back and verify this.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              endy.nicol Endy Nicol (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: