Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: Rushmore
-
Fix Version/s: Mercury
-
Component/s: Other / Misc.
-
Labels:None
-
Environment:
aq-demo-mysql1
-
Sprint:Sprint 20
Description
Impact: Low, only affects the editorial alerts for ads for one account. Since that account is already being modified manually in adwords, the users would see editorial rejections when the log in.
Affected AdWordsAccount: 2581278073
Log file: /var/local/tsa/log/2016-02-27/googlegetdisapprovedads.sh_18.log
Root cause: Someone added an ImageAd to the account.
Fix: update GoogleGetDisapprovedAds and look for where we are casting to TextAd. Check if Ad instanceof TextAd, cast to TextAd, else log warning about unsupported ad type. (Example)
2016-02-27 18:00:08.398 (3) [P1T1]: 2 ads found
2016-02-27 18:00:08.431 (1) [P1T1]: Exception [[SearchEngineUserID: 166] using GoogleGetDisapprovedAds]:java.lang.ClassCastException: com.google.api.ads.adwords.axis.v201506.cm.ImageAd cannot be cast to com.google.api.ads.adwords.axis.v201506.cm.TextAd
at com.thesearchagency.searchengines.google.GoogleGetDisapprovedAds$SearchEngineUserWorker.getDisapprovedAdsFromGoogle(GoogleGetDisapprovedAds.java:370)
at com.thesearchagency.searchengines.google.GoogleGetDisapprovedAds$SearchEngineUserWorker.call(GoogleGetDisapprovedAds.java:227)
at com.thesearchagency.searchengines.google.GoogleGetDisapprovedAds$SearchEngineUserWorker.call(GoogleGetDisapprovedAds.java:210)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
XML Response
2016-02-27 18:00:08,398 [P1T1] INFO c.g.a.a.a.l.c.A.soapXmlLogger - SOAP Response:
<?xml version="1.0" encoding="UTF-8"?>
<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
<soap:Header>
<ResponseHeader xmlns="https://adwords.google.com/api/adwords/cm/v201506">
<requestId>00052cc42fa06c000abf2941830953d3</requestId>
<serviceName>AdGroupAdService</serviceName>
<methodName>get</methodName>
<operations>1</operations>
<responseTime>440</responseTime>
</ResponseHeader>
</soap:Header>
<soap:Body>
<getResponse xmlns="https://adwords.google.com/api/adwords/cm/v201506">
<rval>
<totalNumEntries>2</totalNumEntries>
<Page.Type>AdGroupAdPage</Page.Type>
<entries>
<adGroupId>26775725922</adGroupId>
<ad xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="ImageAd">
<id>86817462282</id>
<displayUrl>opelika-al.gov</displayUrl>
<finalUrls>http://www.opelika-al.gov/Default.asp?ID=146&pg=Accomodations</finalUrls>
<Ad.Type>ImageAd</Ad.Type>
<image>
<type>IMAGE</type>
<referenceId>-996837869597229056</referenceId>
<dimensions>
<key>FULL</key>
<value>
<width>728</width>
<height>90</height>
</value>
</dimensions>
<dimensions>
<key>PREVIEW</key>
<value>
<width>180</width>
<height>22</height>
</value>
</dimensions>
<dimensions>
<key>SHRUNKEN</key>
<value>
<width>728</width>
<height>79</height>
</value>
</dimensions>
<urls>
<key>FULL</key>
<value>https://tpc.googlesyndication.com/simgad/2765137779662913906</value>
</urls>
<urls>
<key>PREVIEW</key>
<value>https://tpc.googlesyndication.com/simgad/16393325326200571038</value>
</urls>
<urls>
<key>SHRUNKEN</key>
<value>https://tpc.googlesyndication.com/simgad/2890623951223109395</value>
</urls>
<mimeType>IMAGE_JPEG</mimeType>
<fileSize>0</fileSize>
<Media.Type>Image</Media.Type>
</image>
<name>bandb_sample.jpg</name>
</ad>
<status>DISABLED</status>
<approvalStatus>DISAPPROVED</approvalStatus>
<disapprovalReasons>Clarity and relevance</disapprovalReasons>
<trademarkDisapproved>false</trademarkDisapproved>
</entries>
<entries>
<adGroupId>26775726042</adGroupId>
<ad xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="ImageAd">
<id>86817470682</id>
<displayUrl>opelika-al.gov</displayUrl>
<finalUrls>http://www.opelika-al.gov/Default.asp?ID=146&pg=Accomodations</finalUrls>
<Ad.Type>ImageAd</Ad.Type>
<image>
<type>IMAGE</type>
<referenceId>-325238575165603840</referenceId>
<dimensions>
<key>FULL</key>
<value>
<width>728</width>
<height>90</height>
</value>
</dimensions>
<dimensions>
<key>PREVIEW</key>
<value>
<width>180</width>
<height>22</height>
</value>
</dimensions>
<dimensions>
<key>SHRUNKEN</key>
<value>
<width>728</width>
<height>79</height>
</value>
</dimensions>
<urls>
<key>FULL</key>
<value>https://tpc.googlesyndication.com/simgad/5279115494959879332</value>
</urls>
<urls>
<key>PREVIEW</key>
<value>https://tpc.googlesyndication.com/simgad/7113592843436041949</value>
</urls>
<urls>
<key>SHRUNKEN</key>
<value>https://tpc.googlesyndication.com/simgad/13039223430014599637</value>
</urls>
<mimeType>IMAGE_JPEG</mimeType>
<fileSize>0</fileSize>
<Media.Type>Image</Media.Type>
</image>
<name>bandb_sample.jpg</name>
</ad>
<status>DISABLED</status>
<approvalStatus>DISAPPROVED</approvalStatus>
<disapprovalReasons>Clarity and relevance</disapprovalReasons>
<trademarkDisapproved>false</trademarkDisapproved>
</entries>
</rval>
</getResponse>
</soap:Body>
</soap:Envelope>
