Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-4251

Refactor UI validation code to reuse it for External API service validation

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: All Time Backlog
    • Component/s: None
    • Labels:
      None
    • Story Points:
      8
    • Sprint:
      Sprint 3

      Description

      Validation was re-implemented in the API since the UI code was not structured in a way that makes it reasonable to reuse the validation logic, however the validation logic itself was the same at the time.

      If we want, we could bring DeploymentUtil out of the API and into sapi-data where it can be shared by the API as well as UI. This way in the future, when validation changes are made they only need to be made in a single place. The validation can still be executed at the highest level, in the UI code and in the API layer, but the code itself can be shared. There is a very significant number of classes in both the API and various layers of the UI that could be eliminated by using the code in sapi-data instead.

      There is no byte counting in the API, this is where we make a decision.
      We can refactor our build so that the code already implemented in the UI can be shared by the API.

      This means we have to re-test the UI byte counting logic one more time after the refactor.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                alok.shukla Alok Shukla
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: