Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: Giraffe
-
Fix Version/s: Giraffe
-
Component/s: Reseller UI
-
Labels:None
-
Environment:
QA 4
aml-sapi-3.1.2-BETA6.war
aml-ui-reseller-gwt-2.9.3-BETA7.war
-
Sprint:Sprint 6
Description
Steps:
1. Create a merchant
2. Click 'Create Order' - Add the details: Destination URL, BA/BL and Budget (without clicking Edit Ads)
3.Deploy the Order
Actual result:
Order stuck in processing state - throws NULL pointer exception!
Snippet of tomcat log:
2016-11-22 13:17:53,569-23056802 [OrderScheduler_Worker-5] DEBUG com.thesearchagency.sapi.services.order.OrderStatusUpdateJob [] - Determining number of orders requiring update.
2016-11-22 13:17:53,607-23056840 [OrderScheduler_Worker-5] INFO com.thesearchagency.sapi.services.order.OrderStatusUpdateJob [] - Beginning update for 1 orders.
2016-11-22 13:17:53,609-23056842 [OrderScheduler_Worker-5] INFO com.thesearchagency.sapi.services.order.OrderService [] - Attempting to update order status for order 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:17:53,610-23056843 [OrderScheduler_Worker-5] DEBUG com.thesearchagency.sapi.services.order.OrderService [] - Modifier ID: f4f232db-9eb9-4b8b-a8e8-23ea009541bb
2016-11-22 13:17:53,610-23056843 [OrderScheduler_Worker-5] DEBUG com.thesearchagency.sapi.services.order.OrderService [] - Modifier Identifier: f4f232db-9eb9-4b8b-a8e8-23ea009541bb
2016-11-22 13:17:53,610-23056843 [OrderScheduler_Worker-5] DEBUG com.thesearchagency.sapi.services.order.DeploymentServiceHelper [] - Checking deployment of order 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:17:53,610-23056843 [OrderScheduler_Worker-5] DEBUG com.thesearchagency.sapi.services.order.DeploymentServiceHelper [] - Getting deployment state from ADS com.thesearchagency.core.common.service.clients.ads.ADSClientFactoryBean$1@2393cb18 for 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:17:53,655-23056888 [OrderScheduler_Worker-5] ERROR com.thesearchagency.sapi.services.order.OrderService [] - Could not check the deployment status for Order[6c8e4d9a-00ea-4431-919c-7a22c72b79dc] due to exception: null!
2016-11-22 13:17:53,657-23056890 [OrderScheduler_Worker-5] ERROR com.thesearchagency.sapi.services.order.OrderService [] - Stack Trace
java.lang.NullPointerException: null
at com.thesearchagency.sapi.services.order.error.ErrorHandler.handle(ErrorHandler.java:92) ~[aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.DeploymentServiceHelper.getDeploymentState(DeploymentServiceHelper.java:220) ~[aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.DeploymentServiceHelper.checkDeploymentState(DeploymentServiceHelper.java:167) ~[aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.OrderService.updateOrderStatus(OrderService.java:787) [aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.OrderService.updateOrderProxyStatus(OrderService.java:743) [aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at sun.reflect.GeneratedMethodAccessor129.invoke(Unknown Source) ~[na:na]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.6.0_24]
at java.lang.reflect.Method.invoke(Method.java:616) ~[na:1.6.0_24]
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:319) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:110) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202) [aml-data-tool-2.9.4-giraffe-20160922.070116-7.jar:2.9.4-giraffe-SNAPSHOT]
at sun.proxy.$Proxy66.updateOrderProxyStatus(Unknown Source) [na:na]
at com.thesearchagency.sapi.services.order.OrderStatusUpdateJob.updateDeployedOrders(OrderStatusUpdateJob.java:130) [aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.OrderStatusUpdateJob.doRunUpdates(OrderStatusUpdateJob.java:85) [aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at com.thesearchagency.sapi.services.order.OrderStatusUpdateJob.execute(OrderStatusUpdateJob.java:57) [aml-order-service-3.1.2-BETA6.jar:3.1.2-BETA6]
at org.quartz.core.JobRunShell.run(JobRunShell.java:213) [quartz-2.1.7.jar:na]
at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:557) [quartz-2.1.7.jar:na]
2016-11-22 13:18:53,569-23116802 [OrderScheduler_Worker-1] DEBUG com.thesearchagency.sapi.services.order.OrderStatusUpdateJob [] - Determining number of orders requiring update.
2016-11-22 13:18:53,609-23116842 [OrderScheduler_Worker-1] INFO com.thesearchagency.sapi.services.order.OrderStatusUpdateJob [] - Beginning update for 1 orders.
2016-11-22 13:18:53,611-23116844 [OrderScheduler_Worker-1] INFO com.thesearchagency.sapi.services.order.OrderService [] - Attempting to update order status for order 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:18:53,612-23116845 [OrderScheduler_Worker-1] DEBUG com.thesearchagency.sapi.services.order.OrderService [] - Modifier ID: f4f232db-9eb9-4b8b-a8e8-23ea009541bb
2016-11-22 13:18:53,612-23116845 [OrderScheduler_Worker-1] DEBUG com.thesearchagency.sapi.services.order.OrderService [] - Modifier Identifier: f4f232db-9eb9-4b8b-a8e8-23ea009541bb
2016-11-22 13:18:53,612-23116845 [OrderScheduler_Worker-1] DEBUG com.thesearchagency.sapi.services.order.DeploymentServiceHelper [] - Checking deployment of order 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:18:53,612-23116845 [OrderScheduler_Worker-1] DEBUG com.thesearchagency.sapi.services.order.DeploymentServiceHelper [] - Getting deployment state from ADS com.thesearchagency.core.common.service.clients.ads.ADSClientFactoryBean$1@2393cb18 for 6c8e4d9a-00ea-4431-919c-7a22c72b79dc
2016-11-22 13:18:53,638-23116871 [OrderScheduler_Worker-1] ERROR com.thesearchagency.sapi.services.order.OrderService [] - Could not check the deployment status for Order[6c8e4d9a-00ea-4431-919c-7a22c72b79dc] due to exception: null!
Expected Result:
Order should get deployed successfully.