Uploaded image for project: 'AdMaxLocal'
  1. AdMaxLocal
  2. AML-4394

ETA : Remove period when converting Description line to Headline

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Giraffe
    • Fix Version/s: Giraffe
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Sprint 8

      Description

      Notes from Nathan.

      Hi Gurpreet,

      There’s one more minor thing I’ve thought of regarding the ad files that I’m hoping we can address after running the ad-conversion script on the existing ad files.

      Most of our current Description 1 lines end in periods. Since D1 is where our new Headline 2s are going to come from for ETAs, that means that most of our H2s will have periods at the end, while our H1s will not. From a presentational POV, I’m concerned that this won’t look good to users or clients.

      After the ETA ad files have been output – and hopefully before actually transitioning live advertisers to ETAs – would it be possible to create/run a script that looks for and eliminates periods at the end of any H2 lines? (Question marks are fine, so no need to remove those.) I think the logic would be: “If last character in H2 column is a period, then remove last character.”

      It’s not the end of the world if this can’t happen, but I think it will look much better to clients to address this up front.

        Attachments

          Activity

            People

            • Assignee:
              varshini.padmanabhan Varshini Padmanabhan (Inactive)
              Reporter:
              gurpreet.singh Gurpreet Singh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: