Uploaded image for project: 'SMB - Optus'
  1. SMB - Optus
  2. OPTUS-101

OPTUS_SGS: Remove site method doesn't remove Site Campaigns from DB

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.5.0
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      QA Environment

      smb-datafeed-ear-1.5.0-RELEASE-p13-t20121213-125346-CI.ear
      optus-ear-1.5.0-RELEASE-p17-t20121213-214434-CI.ear
      tsa-build-bidmgr-2012-12-13-p14-ra39ef05c9c20e259ba474e1a95e814eafbef509c

      Description

      In order to delete a site, you need to make a removeSite request. Conversely, if you want to remove individual campaigns, you send in a deploySite request with the campaigns to delete removed. This will update the DB table referenced below. But removeSite does not update the DB table. The reason this is important is because sitelinks that get built for SEM campaigns reference this table to determine which campaigns exist in the site.

      Steps to reproduce:

      1.Send SGS request having a single campaign -

      {SGS request attached}

      2.Send ADS request for this customer -

      {ADS request attached}

      3.Try to delete campaign by sending updateCampaignStatus method.

      <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:adm="http://www.thesearchagency.com/AdMaxDeploymentService/">
      <soapenv:Header/>
      <soapenv:Body>
      <adm:updateCampaignStatusRequest>
      <header>
      <requestID>1</requestID>
      </header>
      <customerID>789654123-123456</customerID>
      <!-1 or more repetitions:->
      <campaignStatusList>
      <campaignID>deleting-8</campaignID>
      <campaignStatus>terminated</campaignStatus>
      </campaignStatusList>

      </adm:updateCampaignStatusRequest>
      </soapenv:Body>
      </soapenv:Envelope>

      Response shows:

      <resultString>Campaign for BusinessArea / BusinessLocation pair 2000084 / NSW3107 must be deleted from SiteService:deploySite() before it can be deleted from AdMaxDeploymentService:updateCampaignStatus().</resultString>
      (this result is before the fix Paul put in for OPTUS-85)

      4.We can't deploy site without campaign information

      (This would have been worked if Customer has multiple campaigns
      and we try to delete one of them)

      Also I tried this after removing site

      {JBoss log attached}

      <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:sit="http://www.thesearchagency.com/SiteGenerationService/">
      <soapenv:Header/>
      <soapenv:Body>
      <sit:removeSiteRequest>
      <header>
      <requestID>1</requestID>
      <retryID>1</retryID>
      </header>
      <customerID>789654123-123456</customerID>
      </sit:removeSiteRequest>
      </soapenv:Body>
      </soapenv:Envelope>

      But site campaigns still exist for this site in customerBABLocationPairs even though the site is removed.

      mysql> select * from customerBAreaBLocationPairs where customerID='789654123-123456';
      ----------------------------------------------

      customerID businessArea businessLocation

      ----------------------------------------------

      789654123-123456 2000084 10005

      ----------------------------------------------
      1 row in set (0.00 sec)

      Would expect this table to be cleared out, the way it gets cleared when individual campaigns are removed.

        Attachments

        1. ADS_DeletingCampaign
          1 kB
          Atul Sanagar
        2. RemovingSite_JBossLog.txt
          13 kB
          Atul Sanagar
        3. SGS_DeletingCampaign
          3 kB
          Atul Sanagar

          Activity

            People

            • Assignee:
              manasa.denning Manasa Denning
              Reporter:
              atul.sanagar Atul Sanagar (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: