Adextension error (too many sitelinks)

During Optus production daily checks, it was noticed that a brand campaign failed to deploy. After further investigation, it turned out all the campaigns for that account were now failing to deploy during a site link update. The reason was tracked it down to an adExtentionError, caused by the customer having too many site links.

Suggestions for a temporary fix from Caitlyn Duggan:
You could temporarily "shut off" site links and you should be able to deploy successfully. That setting is in $JBOSS_HOME/server/<node>/conf/tsa/smb/smb-admax-deployment-service.properties. I don't think it exists in Optus (code assumes if it's missing it's true) so add this line:

smb-admax-deployment-service.feature.siteLinks=false

When it comes to the properties files, I'm not sure if a jboss restart is required or not..
I'm not sure of another way to workaround this issue.

Suggestion for actual fix from Caitlyn Duggan:

Just looked at recent git commits and found the culprit. It was due to trying to fix OPTUS-85 but it was my fault (sorry ). I commented out the old way of getting SiteService campaigns and forgot to bring over the "max of 10" logic. To resolve, in AdMaxDeploymentServiceImpl.java look for this comment in getCampaignSiteLinks(): "2012-12-12 cduggan commented out due to AML-940"
You'll see the logic there. OPTUS-85 was one of the last-minute fixes so we probably didn't do a whole regression test after it.