Uploaded image for project: 'SMB - Optus'
  1. SMB - Optus
  2. OPTUS-64

Optus ADS: updateCampaignStatus should write directly to tsacommon.searchEngineAccounts instead of calling seupdate

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None
    • Environment:

      optus prod environment

      Description

      This improvement is logged due to an issue discovered in Optus' production environment (email thread "ACTIVE_PROJECTS.TB982_Optus_Digital_Agency - Defect #448 - ODA: PPT: Cancel Scenario failed with TSA")

      Problem is that the updateCampaignStatus call takes too long to respond (synchronous call) & the web service times out after 60 seconds. Jason looked into this and determined a big chunk of the time is spent in the seupdate process, which runs after the status is updated at AdWords.

      As suggested by the name, the only thing this call affects is the campaign status. seupdate --accounts handles status and targeting. updateCampaignStatus call will never affect targeting, so it's inefficient to run seupdate. Instead, to improve performance, have the Admax Listener write directly to the tsacommon.searchEngineAccounts table to update the status.

      Note that our SLA says Optus can only send 12 campaigns at a time (this issue in the email thread came from them sending 216 campaigns in one call) and that the web service should time out after 120 seconds (not 60 seconds))

      Note that after this improvement is made, draft deployments will be implemented (see https://www.pivotaltracker.com/story/show/21177103)

        Attachments

          Activity

          Hide
          caitlyn Caitlyn Duggan (Inactive) added a comment - - edited

          Resolved in:

          SMB Core - Bid Manager - 1.3.0 - RELEASE Pulse build 39

          Commit: https://github.com/thesearchagency/core/commit/cd2f7cb521e84e8ba4a5666f569d76d9798a1caf

          Show
          caitlyn Caitlyn Duggan (Inactive) added a comment - - edited Resolved in: SMB Core - Bid Manager - 1.3.0 - RELEASE Pulse build 39 Commit: https://github.com/thesearchagency/core/commit/cd2f7cb521e84e8ba4a5666f569d76d9798a1caf
          Hide
          caitlyn Caitlyn Duggan (Inactive) added a comment -

          QA - to test this, run with a bidmgr build prior to 628 and note that seupdate.sh --accounts is called

          Then run with latest bidmgr build and verify seupdate is not called (but the 'searchEngineStatus' and 'searchEngineStatusText' columns are updated in tsacommon.searchEngineAccounts)

          Show
          caitlyn Caitlyn Duggan (Inactive) added a comment - QA - to test this, run with a bidmgr build prior to 628 and note that seupdate.sh --accounts is called Then run with latest bidmgr build and verify seupdate is not called (but the 'searchEngineStatus' and 'searchEngineStatusText' columns are updated in tsacommon.searchEngineAccounts)
          Hide
          atul.sanagar Atul Sanagar (Inactive) added a comment -

          Issue is retested with the latest trunk build. 'seupdate' script is called automatically while we deploy ADS. Hence closing this issue.

          Show
          atul.sanagar Atul Sanagar (Inactive) added a comment - Issue is retested with the latest trunk build. 'seupdate' script is called automatically while we deploy ADS. Hence closing this issue.

            People

            • Assignee:
              caitlyn Caitlyn Duggan (Inactive)
              Reporter:
              caitlyn Caitlyn Duggan (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: