Google validation api calls issue

Testing Notes:

We made changes to GoogleAdwordsAPI class that has almost all the calls that TSA makes to Google Adwords. A detailed testing will be required to QA this task. It is a bit tricky to test Rate Exceeded scenario because not always Google return this error. I would recommend doing the following and then doing a bit of load/regression testing for the confidence.

1. Creation on an account in Google.
2. Update Adgroups, campaigns status and keywords of a campaign.
3. Update targets, using advert level radii, and budget of a campaign.
4. Finally for read-only calls run seupdate and GCE sync.

Once completed please do that for multiple accounts, the idea is to hit adwords a little hard in hope that Google might throw Rate Exceeded Error.

When the validation service is used, it throws all exceptions (editorial and system exceptions like database errors, internal errors, RateExceeded errors).

I think we need to filter the returned errors and if they contain retryable errors (like internal errors) we retry ... but if it's full of editorial errors, we return the editorial errors.

Here's the code in GoogleAdWordsAPI:

checkAds()

try

{ AdGroupAdReturnValue adGroupAdReturnValue = getValidationAdService().mutate(adGroupAdOperations); }

catch (ApiException e)

{ ret = e.getErrors(); }







checkCriteria()

try { AdGroupCriterionReturnValue adGroupCriterionReturnValue = getValidationAdGroupCriterionService().mutate(adGroupAdOperations); }

catch (ApiException e) { ret = e.getErrors(); }