destinationURL not being auto-tagged with refcd & tsacr on campaign deployment

Okay, in that case, I'm just going to open a bug for it I still need to test sepull147, sedatacheck, etc. for data discrepancies and I'm supposed to be back on Optus on Monday!

________________________________________

From: Jeff Theroux

Sent: Wednesday, April 18, 2012 4:49 PM

To: Caitlyn Duggan

Cc: Ramesh Ramakrishnan

Subject: Re: destination url with tsacr / refcd

Well, below is quite the variety of true/false but I found some tagging

related stuff where the values are set to true or false and then passed

into the listener. again, this is yell trunk not the bing branch.

== mms repository ==

therouxj@therouxj-o960:~/shared/murky/mms-trunk/services$ grep -ri

'TaggingEnabled' * --include '*.java'

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

ret.setIsTaggingEnabled(enableTagging);

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

ret.setIsTaggingEnabled(enableTagging);

AdMaxService/ejb/src/test/java/com/thesearchagency/mms/systest/EJBTest.java:

System.out.println(info.isTaggingEnabled());

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/IMMSAccountStructure.java:

public boolean isTaggingEnabled();

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/IMMSAccountStructure.java:

public void setIsTaggingEnabled(boolean anIsTaggingEnabledFlag);

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

public MMSURLInfo(String aDisplayURL, String aDestinationURL,

boolean anIsTaggingEnabledFlag)

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

setIsTaggingEnabled(anIsTaggingEnabledFlag);

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

public boolean isTaggingEnabled()

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

return theIsTaggingEnabledFlag;

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

public void setIsTaggingEnabled(boolean anIsTaggingEnabledFlag)

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

theIsTaggingEnabledFlag = anIsTaggingEnabledFlag;

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

sb.append("taggingEnabled: ");

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

sb.append(theIsTaggingEnabledFlag);

CommonUtils/src/main/java/com/thesearchagency/mms/utils/messages/MMSAccountStructure.java:

private boolean theIsTaggingEnabledFlag;

therouxj@therouxj-o960:~/shared/murky/mms-trunk/services$ grep -ri

'enabletagging' * --include '*.java'

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

boolean enableTagging;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

enableTagging = false;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

enableTagging = true;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

ret.setIsTaggingEnabled(enableTagging);

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

boolean enableTagging;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

enableTagging = false;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

enableTagging = false;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

enableTagging = true;

AdMaxService/ejb/src/main/java/com/thesearchagency/mms/admax/AdMaxServiceEJB.java:

ret.setIsTaggingEnabled(enableTagging);

== bidmgr ==

therouxj@therouxj-o960:~/shared/murky/trunk-clean/src/bidmgr/src/com/thesearchagency/admaxlistener$

grep -ri 'autotag' * --include '*.java'

GoogleStructureMapper.java:

next.setAutoTag(aURLInfo.isTaggingEnabled());

worker/CampaignUpdateWorker.java:

Debug.msg(Debug.INFORMATION, "AutotagEnabled " + gceInfo.getName() +": "

+ doTagging);

On 04/18/2012 04:36 PM, Caitlyn Duggan wrote:

> Actually, for Google and Bing that value is hardcoded to be false, which is why I was trying to find a place where that value is overridden (no luck so far, but I've stopped looking).

>

> //Google

> cduggan@ivlyn:~/repositories/yell/yell-bidmgr-bingIntegration-2012-02-08-01/src/bidmgr/src/com/thesearchagency/searchengines/google/contenteditor/dto/criterion$ less CriterionInfo.java | grep 'boolean doAutoTag ='

> private boolean doAutoTag = false;

>

> //Bing

> cduggan@ivlyn:~/repositories/yell/yell-bidmgr-bingIntegration-2012-02-08-01/src/bidmgr/src/com/thesearchagency/searchengines/bing/contenteditor/dto/criterion$ less CriterionInfo.java | grep 'boolean doAutoTag ='

> private boolean doAutoTag = false;

>

>

> I'll try changing that value to be true and see if that handles auto-tagging. I'm hoping this works, though, due to the error that was returned when I tried to add refcd& tsacr to the destinationURL in the request... I did create YELL-611 as a minor bug, assigned to no one, just to track the error I saw when adding refcd and tsacr to the destinationURL in the campaign deployment request. If setting the value to true does add refcd& tsacr but YELL-611 happens, or if setting it to true doesn't add refcd& tsacr, I'll leave it as false and open a minor bug to handle auto-tagging.

> ________________________________________

> From: Jeff Theroux

> Sent: Wednesday, April 18, 2012 4:29 PM

> To: Caitlyn Duggan

> Cc: Ramesh Ramakrishnan

> Subject: Re: destination url with tsacr / refcd

>

> And yes, it should be, so feel free to open a bug if necessary.

>

> On 04/18/2012 04:28 PM, Jeffrey Theroux wrote:

>> In the GCE, the tagging was called if the getAutoTag() or

>> isAutoTagged() (or something like that) method is set to true. I

>> believe it's hard coded somewhere to true.

>>

>> I assume it works the same in Bing COntent Edtioir.

>>

>> These greps will help you find all references to auto tag if you need it.

>>

>> 1) from the

>> src/bidmgr/src/com/thesearchagency/searchengines/google/contenteditor

>> directory: grep -ri 'autotag' *

>>

>> (among other references)

>> RequestCreator.java: public int

>> updateAllDestinationURLs(List<Integer> aCampaignIDs, String

>> aDisplayURL, String aDestinationURL, boolean doAutoTag) throws

>> TransactionException, SQLException

>>

>>

>> 2) from the admaxlistener directory: grep -r 'updateAllDestinationURLs' *

>>

>> admaxlistener/worker/CampaignUpdateWorker.java: updates

>> = gceRequest.updateAllDestinationURLs(idSingleton, displayURL,

>> destinationURL, doTagging);

>>

>>

>> I did those greps from the Optus code base so the Yell code base might

>> be different.

>>

>>

>> On 04/18/2012 03:44 PM, Caitlyn Duggan wrote:

>>> Okay thanks Jeph. I see the logic you mention in the code, about it

>>> only adding the refcd and tsacr if it's not already in the

>>> destinationURL (it was using Google rules, so I updated it to use

>>> Bing). What I'm having trouble finding is how that method even gets

>>> called. But since this is low priority, I'll stop looking into it.

>>> But the behavior I am seeing is that the destinationURL is not being

>>> auto-tagged. If it should be, let me know and I can open a

>>> low-priority bug for it so we can track it.

>>>

>>> You are right, sesumm does NOT use altKey to get sources.

>>> ________________________________________

>>> From: Jeff Theroux

>>> Sent: Wednesday, April 18, 2012 3:27 PM

>>> To: Caitlyn Duggan

>>> Cc: Ramesh Ramakrishnan

>>> Subject: Re: destination url with tsacr / refcd

>>>

>>> +Ramesh because he would know more about how the Omniture tags are used.

>>>

>>> Caitlyn, Don't let destination URL refcd tagging hold you up too much.

>>> It's kind of a low priority since since the only place it would show up

>>> is Omniture reports and I don't know if we actually need correct refcds

>>> in there (I think we would probably just need some sort of value). I

>>> believe getCostAndClicks() for MSN does not use altKey to find the

>>> source (right?).

>>>

>>> I forgot since AdCenter supports

{OrderItemID} as the substitution

>>> parameter we actually don't need to substitute a keyword ID. Google does

>>> not have any sort of {criterionID} substitution parameter so that's why

>>> we need to go back and append our internal ID after it is inserted into

>>> the DB for Google.

>>>

>>> I think the auto tagging stuff checks for the existence of a refcd/tsacr

>>> and if it exists, it does not auto tag because it wouldn't want to

>>> overwrite an existing one or append a second refcd parameter. If you use

>>> a custom URL without a refcd and tsacr it should put one in for you.

>>>

>>> If you have questions about how we should tag refcd/tsacr in destination

>>> URLs for AdCenter, Jeff Shih is the best person to ask. He'll be able to

>>> get you the answers you're looking for, but I think we could do one of

>>> two things.

>>>

>>> 1) leave keyword destination URL blank and have the Ad destination URL

>>> look below. I believe the correct keyword ID, match type, and AdID would

>>> get substituted in on a click (according to the documentation below). In

>>> earlier versions of AdCenter those parameters were only supported at

>>> keyword level:

>>>

>>> http://<domain

>>> name>/<page>?refcd=ms{OrderItemID} {MatchType}&tsacr=ms{AdId}

>>>

>>> 2) this is what we used to do for Agency when MSN was at very early

>>> versions and this scheme would still work.

>>>

>>> text ad destination URL = {param1}

>>> keyword destination URL = http://<domain

>>> name>/<page>?refcd=ms{OrderItemID}{MatchType}

&tsacr=ms

{AdId}

>>>

>>> Here's some supporting documentation in addition to the TSA wiki

>>> articles I sent earlier.

>>>

>>> Text Ad Destination URL element

>>> http://msdn.microsoft.com/en-US/library/bb672081.aspx#DestinationUrl_Element_htm

>>>

>>>

>>> Keyword (this page states "Typically, you use the

{Param1}

substitution

>>> string in the DestinationUrl element of an ad.")

>>> http://msdn.microsoft.com/en-US/library/bb671833.aspx

>>>