Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: Wickford
-
Fix Version/s: Goa
-
Component/s: None
-
Labels:None
-
Story Points:5
-
Sprint:Goa Sprint 2
Description
When AdGroups don't get created in Google due to an error that causes the content editor to stop before running handleAdGroups(), handleAds() and handleKeywords(), the listener still thinks the deployment is successful (but it failed).
In once case, this was due to Google removing the suggested mobile bid modifier. However, any unexpected NullPointerException or other exception could cause the content editor to bail.
I think the fix for this would be to add error checking to the listener to check and make sure at least one AdGroup was successfully created. That would be done in com.thesearchagency.admaxlistener.worker.AccountWorker.processGCEResults() probably by adding a new method or modifying com.thesearchagency.searchengines.google.contenteditor.dao.error.ErrorDAO() / com.thesearchagency.searchengines.google.contenteditor.GoogleContentEditor.getOperationErrors().
==> /var/local/tsa/log/tsa-admax-jmslistener/tsa-admax-jmslistener.log <==
2013-10-14 18:14:11.919 (2) [P875T1]: Exception [Exception running content editor, quitting]:java.lang.NullPointerException
at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:989)
at java.lang.Double.parseDouble(Double.java:510)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.CampaignTargetChangeRequest.createNewCampaignCriterionDTO(CampaignTargetChangeRequest.java:264)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.CampaignTargetChangeRequest.convertTargetingToGoogle(CampaignTargetChangeRequest.java:220)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.CampaignTargetChangeRequest.getTargetList(CampaignTargetChangeRequest.java:189)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.CampaignTargetChangeRequest.createRequest(CampaignTargetChangeRequest.java:60)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.CampaignTargetChangeRequest.createRequest(CampaignTargetChangeRequest.java:48)
at com.thesearchagency.searchengines.google.contenteditor.changerequest.BaseChangeRequest.makeRequest(BaseChangeRequest.java:112)
at com.thesearchagency.searchengines.google.contenteditor.GoogleContentEditor$SearchEngineUserWorker.handleCampaignTargets(GoogleContentEditor.java:1237)
at com.thesearchagency.searchengines.google.contenteditor.GoogleContentEditor$SearchEngineUserWorker.run(GoogleContentEditor.java:960)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
2013-10-14 18:14:11.919 (3) [P875T1]: ... SEUser 28 finished
2013-10-14 18:14:11.920 (3) [pool-3-thread-23]: ------------Google Content Editor done
2013-10-14 18:14:12.010 (3) [pool-3-thread-23]: 64_MO has no applicable GCE errors.
2013-10-14 18:14:12.015 (3) [pool-3-thread-23]: 64_GM has no applicable GCE errors.
2013-10-14 18:14:12.027 (3) [pool-3-thread-23]: 64_GT has no applicable GCE errors.
2013-10-14 18:14:12.028 (3) [pool-3-thread-23]: Finished DEPLOY request for campaign 92cd4682-c776-4106-a465-e92782215576_11210_12619_64_GT: SUCCEEDED
2013-10-14 18:14:12.029 (3) [pool-3-thread-23]: Finished DEPLOY request for campaign 92cd4682-c776-4106-a465-e92782215576_11210_12619_64_GM: SUCCEEDED
2013-10-14 18:14:12.030 (3) [pool-3-thread-23]: Finished DEPLOY request for campaign 92cd4682-c776-4106-a465-e92782215576_11210_12619_64_MO: SUCCEEDED
2013-10-14 18:14:12.030 (3) [pool-3-thread-23]: 92cd4682-c776-4106-a465-e92782215576 has 3 campaigns for a SE Update accounts sync.
2013-10-14 18:14:12.030 (3) [pool-3-thread-23]: 92cd4682-c776-4106-a465-e92782215576 has 3 campaigns for a SE Update groups-listings sync.
2013-10-14 18:14:17.030 (3) [pool-3-thread-23]: JobExecutor running job [2013-10-14_181412_a29_AccountWorkerProcessResults_syncAccountsGroupsListings_PS2mNHNiGr]: /usr/local/tsa/bidmgr/seupdate.sh -d 3 --inactive --accountid 29 --accounts --seaccount 79,80,81 --groups --listings
INSTRUCTIONS TO TEST/REPRODUCE:
Remove a property (like ce.mobilebidmodifier) from contenteditor.properties
Attachments
Issue Links
- depends on
-
AML-2360 Remove all references to the forward compatibility map
- Closed