Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.2.0
-
Fix Version/s: 1.0.0
-
Component/s: AdMax Deployment Service
-
Labels:None
-
Environment:
bidmgr trunk revision 1904
Description
When the validation service is used, it throws all exceptions (editorial and system exceptions like database errors, internal errors, RateExceeded errors).
I think we need to filter the returned errors and if they contain retryable errors (like internal errors) we retry ... but if it's full of editorial errors, we return the editorial errors.
Here's the code in GoogleAdWordsAPI:
checkAds()
try
{ AdGroupAdReturnValue adGroupAdReturnValue = getValidationAdService().mutate(adGroupAdOperations); }catch (ApiException e)
{ ret = e.getErrors(); }checkCriteria()
try { AdGroupCriterionReturnValue adGroupCriterionReturnValue = getValidationAdGroupCriterionService().mutate(adGroupAdOperations); }
catch (ApiException e) { ret = e.getErrors(); }
Attachments
Issue Links
- cloned to
-
YELL-560 Google validation api calls issue
- Closed